Webplanner - route history duplicate entry
Hi
Great to see Route History (Undo/Redo) in the Web Planner!
I came across a minor issue regarding the handling of insertion boxes in the itinerary. The design seems to be that these are all first removed before an undo or redo is executed which then acts on real points. However if you do the following sequence it isn't consistent:
Create a route with a few points.
Do an 'undo' - last (real) point is removed.
Then create an insertion box anywhere in the route using the itinerary.
Do an 'undo' - the insertion box gets removed, but no action on any real point - which is unexpected.
Do a redo - nothing happens.
Do an undo - nothing happens.
Do an undo - last point is removed.
Do a redo - point re-added
Do a redo - nothing happens
etc.
Seems that a duplicate entry has been added in the history stack, which happens when you add an insertion box after already having done an undo.
The same problem 
Hi,
It is not just the presence of the insertion point which causes it. It also happens if a point is actually added using the itinerary.
So for example:
Create route with a few points.
Do undo - last point removed.
Create insertion box at end of route.
Enter a point either by searching for a lopoint, or enter Lat/Lng and confirm - point is added.
Do undo - point is removed.
Do undo - nothing happens.
There is a no-operation entry (probably duplicate state) in the history list/stack.
Hi,
It is not just the presence of the insertion point which causes it. It also happens if a point is actually added using the itinerary.
So for example:
Create route with a few points.
Do undo - last point removed.
Create insertion box at end of route.
Enter a point either by searching for a lopoint, or enter Lat/Lng and confirm - point is added.
Do undo - point is removed.
Do undo - nothing happens.
There is a no-operation entry (probably duplicate state) in the history list/stack.
Looking at the sequence of URLS it seems that the state with the insertion point has a different URL to that without. So I'm guessing that the history does record the existence of these 'gaps' and undo/redo does use those history entries but when the resulting route/itinerary is shown it does not show the insertion points in the itinerary, hence it appears as if nothing has changed.
Personally I think insertion points should be respected and treated the same as real points when doing undo/redo. So if the above is correct then when the entry with such points is shown it should include showing the insertion points in the itinerary.
IMO if you have just created a bunch of insertion points then you would probably expect undo to remove them one by one, not to wipe them out and remove the last real point changed.
Looking at the sequence of URLS it seems that the state with the insertion point has a different URL to that without. So I'm guessing that the history does record the existence of these 'gaps' and undo/redo does use those history entries but when the resulting route/itinerary is shown it does not show the insertion points in the itinerary, hence it appears as if nothing has changed.
Personally I think insertion points should be respected and treated the same as real points when doing undo/redo. So if the above is correct then when the entry with such points is shown it should include showing the insertion points in the itinerary.
IMO if you have just created a bunch of insertion points then you would probably expect undo to remove them one by one, not to wipe them out and remove the last real point changed.
Hi Alan,
thanks, this bug should be fixed soon.
Hi Alan,
thanks, this bug should be fixed soon.
Thanks. I just saw another not-major oddity - I'll raise a separate case for it.
Thanks. I just saw another not-major oddity - I'll raise a separate case for it.
Replies have been locked on this page!